-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1228 - Improves webhooks to send labels at once #1566
Commits on May 19, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c6b2bb0 - Browse repository at this point
Copy the full SHA c6b2bb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc2a869 - Browse repository at this point
Copy the full SHA cc2a869View commit details -
Issue webcompat#1228 - Adds LOCALHOST key for Webhooks
- We use the LOCALHOST key for testing - Takes this opportunity to straighten a bit the way we create import.
Configuration menu - View commit details
-
Copy full SHA for 3ff3e04 - Browse repository at this point
Copy the full SHA 3ff3e04View commit details -
Issue webcompat#1228 - Removes dump to DB feature
We might want to do that in the future but for now, it is basically unused code.
Configuration menu - View commit details
-
Copy full SHA for 5f9294c - Browse repository at this point
Copy the full SHA 5f9294cView commit details -
Issue webcompat#1228 - Changes signature computation in 2 functions
The goal is to make the function more usable in web hooks tests. We now have a function to check and one to compute a signature. It makes also fixtures independent with regards to content change.
Configuration menu - View commit details
-
Copy full SHA for c49ef3e - Browse repository at this point
Copy the full SHA c49ef3eView commit details -
Issue webcompat#1228 - Adds tests for webhooks
Only one case is not tested for now, when basically we are communicating with GitHub. There are a couple of strategies for mocking the service. It needs a bit more cycles of thinking.
Configuration menu - View commit details
-
Copy full SHA for c6c7980 - Browse repository at this point
Copy the full SHA c6c7980View commit details -
Issue webcompat#1228 - Makes labeler route slimmer
- Removes the GET. Flask handles this already for us - Creates only 1 requests for setting labels instead of two, probably avoiding race condition mentioned in webcompat#1553 - Sends plain/text messages where it is granted. - Logs the failure when tagging didn’t happen properly - Renames set_label as set_labels and rationalises the functions
Configuration menu - View commit details
-
Copy full SHA for 0fea5eb - Browse repository at this point
Copy the full SHA 0fea5ebView commit details
Commits on May 24, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5f5b6e9 - Browse repository at this point
Copy the full SHA 5f5b6e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39874cb - Browse repository at this point
Copy the full SHA 39874cbView commit details