Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1228 - Improves webhooks to send labels at once #1566

Merged
merged 9 commits into from
May 24, 2017

Commits on May 19, 2017

  1. Configuration menu
    Copy the full SHA
    c6b2bb0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cc2a869 View commit details
    Browse the repository at this point in the history
  3. Issue webcompat#1228 - Adds LOCALHOST key for Webhooks

    - We use the LOCALHOST key for testing
    - Takes this opportunity to straighten a bit the way we create import.
    karlcow committed May 19, 2017
    Configuration menu
    Copy the full SHA
    3ff3e04 View commit details
    Browse the repository at this point in the history
  4. Issue webcompat#1228 - Removes dump to DB feature

    We might want to do that in the future but for now, it is basically
    unused code.
    karlcow committed May 19, 2017
    Configuration menu
    Copy the full SHA
    5f9294c View commit details
    Browse the repository at this point in the history
  5. Issue webcompat#1228 - Changes signature computation in 2 functions

    The goal is to make the function more usable in web hooks tests.
    We now have a function to check
    and one to compute a signature.
    It makes also fixtures independent with regards to content change.
    karlcow committed May 19, 2017
    Configuration menu
    Copy the full SHA
    c49ef3e View commit details
    Browse the repository at this point in the history
  6. Issue webcompat#1228 - Adds tests for webhooks

    Only one case is not tested for now, when basically we are
    communicating with GitHub.
    There are a couple of strategies for mocking the service. It needs a
    bit more cycles of thinking.
    karlcow committed May 19, 2017
    Configuration menu
    Copy the full SHA
    c6c7980 View commit details
    Browse the repository at this point in the history
  7. Issue webcompat#1228 - Makes labeler route slimmer

    - Removes the GET. Flask handles this already for us
    - Creates only 1 requests for setting labels instead of two, probably
    avoiding race condition mentioned in webcompat#1553
    - Sends plain/text messages where it is granted.
    - Logs the failure when tagging didn’t happen properly
    - Renames set_label as set_labels and rationalises the functions
    karlcow committed May 19, 2017
    Configuration menu
    Copy the full SHA
    0fea5eb View commit details
    Browse the repository at this point in the history

Commits on May 24, 2017

  1. Configuration menu
    Copy the full SHA
    5f5b6e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    39874cb View commit details
    Browse the repository at this point in the history