Fixes #1360. Provide a param to assign a label to a new issue. #1453

miketaylr · 2017-03-28T22:17:16Z

Not ready for review, just opening as a place for discussion right now.

webcompat/form.py

-    return {'title': summary, 'body': body}
+    rv = {'title': summary, 'body': body}
+    if 'label' in form_object:
+        rv.update({'labels': [form_object.get('label')]})


miketaylr · 2017-04-04T13:34:10Z

@karlcow any ideas here? the original plan is here: #1360 (comment), but done this way, anybody could add any arbitrary label to our repo because @webcompat-bot has elevated privs.

miketaylr · 2017-04-04T21:37:13Z

The other approach I was thinking about was to fetch the current labels via the API when the app is booted, and keep those in memory. Or we could have a yaml file or similar in the project config, and parse that on app boot-up.

It really just depends on where we want to manage what labels exist for the web-bugs repo.

If there's a match for an already existing label, we add it via the labeler webhooks. If there isn't a match, we ignore it.

karlcow · 2017-04-04T22:50:50Z

I don't think the creation of labels will be intense. Or at least it should not. We are not in the free tagging business. So I would make a list of accepted labels and use the webhooks.

Benefits it gives us an overview of all labels. And we have already code, we can export in a new module dedicated to labels.

miketaylr · 2017-04-04T22:52:24Z

Cool, thanks @karlcow . I'll cook something up in the next few days.

We are not in the free tagging business.

Speak for yourself... 🎆

karlcow · 2017-04-04T23:02:35Z

@miketaylr The code in my previous comment relates to namedtuples, a cheap way to create structured objects.

>>> categories = CATEGORIES
>>> categories
[Category(name='needstriage', dataAttribute='needstriage', label='Needs Triage'), Category(name='needsDiagnosis', dataAttribute='needsdiagnosis', label='Needs Diagnosis'), Category(name='needsContact', dataAttribute='needscontact', label='Needs Contact'), Category(name='ready', dataAttribute='contactready', label='Ready for Outreach'), Category(name='sitewait', dataAttribute='sitewait', label='Site Contacted'), Category(name='close', dataAttribute='closed', label='Closed')]
>>> categories[0].name
'needstriage'
>>> categories[0].dataAttribute
'needstriage'
>>> categories[0].label
'Needs Triage'

but we can change that to another model if we prefer or if this one is too confusing. No issue for me.
YAML, JSON, n3, rdf, cvs, turtle, name your own evil.

miketaylr · 2017-04-12T21:19:02Z

I don't think the creation of labels will be intense. Or at least it should not. We are not in the free tagging business. So I would make a list of accepted labels and use the webhooks.

One concern I have about this is browsers that we dont currently know about wont get their automatic labels. But maybe thats not a big issue.... If the triagers note it, they can file a bug and we can just add that new label to the config.

miketaylr · 2017-04-12T21:36:00Z

Oh wait, I'm totally overthinking this. We can just have a small set of labels to whitelist what can be set via the extra_labels param, which for now will be 1 or 2 (type-media, type-webvr). That won't affect the labeler webhook.

karlcow · 2017-04-13T01:39:41Z

@miketaylr yup. The benefit of having category-label is that we can adjust our policy depending on the category-. We can still have limited vocab for some of them.

miketaylr · 2017-04-14T16:32:03Z

(update: i wrote patches for this 2 nights ago, hope to get them up for review today or over the weekend)

webcompat/views.py

@@ -165,8 +165,9 @@ def create_issue():
        bug_form = get_form(request.headers.get('User-Agent'))
        if g.user:
            get_user_info()
-        if request.args.get('src'):
-            session['src'] = request.args.get('src')
+        for param in ['src', 'label']:


miketaylr · 2017-04-14T20:15:52Z

So, I guess type-media reports are coming in already, so landing this sooner than later will make less of a headache for triagers (cc @MDTsai @karlcow @adamopenweb).

Not 100% sure about tests, since we don't directly test issue creation.

r? @karlcow

karlcow

Good to go for me.

webcompat/views.py

@@ -165,8 +165,9 @@ def create_issue():
        bug_form = get_form(request.headers.get('User-Agent'))
        if g.user:
            get_user_info()
-        if request.args.get('src'):
-            session['src'] = request.args.get('src')
+        for param in ['src', 'label']:


webcompat/form.py

+    extra_label = form_object.get('label', None)
+    if extra_label and extra_label in app.config['EXTRA_LABELS']:
+        rv.update({'labels': [extra_label]})
+    return rv


miketaylr added the in progress label Mar 28, 2017

miketaylr commented Mar 28, 2017

View reviewed changes

webcompat/form.py Outdated

return {'title': summary, 'body': body}

rv = {'title': summary, 'body': body}

if 'label' in form_object:

rv.update({'labels': [form_object.get('label')]})

This comment was marked as abuse.

Sign in to view

Mike Taylor added 4 commits April 12, 2017 17:03

Issue #1360. Add label to form object + session if present.

3c24a6e

Issue #1360. Pass along form_object.label to GitHub if present.

500f2b0

Issue #1360. session.label wont exist if ur already logged in

de8b097

Issue #1360. Move get_form into form module to prevent circular import.

6a6abdc

Issue #1360. Create an EXTRA_LABELS config whitelist.

c613a78

miketaylr force-pushed the issues/1360/1 branch from 2d479aa to c613a78 Compare April 14, 2017 20:10

miketaylr commented Apr 14, 2017

View reviewed changes

karlcow self-requested a review April 17, 2017 00:13

karlcow approved these changes Apr 17, 2017

View reviewed changes

karlcow merged commit 6b27c28 into master Apr 17, 2017

karlcow added status: add to changelog and removed in progress labels Apr 17, 2017

karlcow deleted the issues/1360/1 branch April 17, 2017 00:23

miketaylr removed the status: add to changelog label Apr 24, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #1360. Provide a param to assign a label to a new issue. #1453

Fixes #1360. Provide a param to assign a label to a new issue. #1453

miketaylr commented Mar 28, 2017 •

edited

Loading

This comment was marked as abuse.

miketaylr commented Apr 4, 2017

miketaylr commented Apr 4, 2017

karlcow commented Apr 4, 2017

miketaylr commented Apr 4, 2017

karlcow commented Apr 4, 2017

miketaylr commented Apr 12, 2017

miketaylr commented Apr 12, 2017 •

edited

Loading

karlcow commented Apr 13, 2017

miketaylr commented Apr 14, 2017

This comment was marked as abuse.

This comment was marked as abuse.

miketaylr commented Apr 14, 2017

karlcow left a comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

Fixes #1360. Provide a param to assign a label to a new issue. #1453

Fixes #1360. Provide a param to assign a label to a new issue. #1453

Conversation

miketaylr commented Mar 28, 2017 • edited Loading

This comment was marked as abuse.

miketaylr commented Apr 4, 2017

miketaylr commented Apr 4, 2017

karlcow commented Apr 4, 2017

miketaylr commented Apr 4, 2017

karlcow commented Apr 4, 2017

miketaylr commented Apr 12, 2017

miketaylr commented Apr 12, 2017 • edited Loading

karlcow commented Apr 13, 2017

miketaylr commented Apr 14, 2017

This comment was marked as abuse.

This comment was marked as abuse.

miketaylr commented Apr 14, 2017

karlcow left a comment

Choose a reason for hiding this comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

miketaylr commented Mar 28, 2017 •

edited

Loading

miketaylr commented Apr 12, 2017 •

edited

Loading