Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on filter dropdown causes a request #507

Closed
miketaylr opened this issue Dec 23, 2014 · 4 comments
Closed

Clicking on filter dropdown causes a request #507

miketaylr opened this issue Dec 23, 2014 · 4 comments

Comments

@miketaylr
Copy link
Member

Should only request when a selection is made, not before.

@miketaylr
Copy link
Member Author

Hmm, I'm not sure it actually creates a request. I thought it did when I reported this... but it doesn't reproduce. I do sometimes see a flash like the spinner is being activated. But not consistently. So there's a bug somewhere... 🔍

@magsout are you seeing requests in the Network panel of devtools?

@miketaylr
Copy link
Member Author

Erm... in Chrome and Safari it won't even open the dropdown at all. I just get the spinner for a split second.

@miketaylr
Copy link
Member Author

So, I don't exactly understand why, but adding pointer-events: none to .Dropdown-label fixes the issue of not opening in Chrome/Safari. I wonder if it's because we're doing clever things like <button><h1>foo</h1></button>. Not sure.

I'm going to go ahead and deploy that tweak because otherwise dropdowns are just broken for Blink/WebKit browsers. We can figure out the rest of this bug later.

@miketaylr
Copy link
Member Author

Just noticed that clicking on the "chevron" arrow opens the dropdown in Gecko, but not in Blink/WebKit. To investigate. And now, when I'm on master I get the consistent "open dropdown, get a network request" behavior.

magsout added a commit that referenced this issue Jan 2, 2015
Fix #507 - Scope toggleFilter to more specific class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant