Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue comment - Parse hashtag on comment #501

Closed
magsout opened this issue Dec 20, 2014 · 16 comments
Closed

Issue comment - Parse hashtag on comment #501

magsout opened this issue Dec 20, 2014 · 16 comments

Comments

@magsout
Copy link
Member

magsout commented Dec 20, 2014

Like
capture d ecran 2014-12-20 a 11 06 24

I have to go on Github to see the correct issue.

@karlcow
Copy link
Member

karlcow commented Dec 21, 2014

yes good point and plus I think we could make it better than GitHub. Let's not just implement the github feature.

  • A link to the issue
  • Maybe a status icon through CSS content or background image?
  • A title attribute with the name of the issue.

@miketaylr
Copy link
Member

Good suggestions. I should also probably add our fork of marked.js to the repo as well.

Adding needs-design label for status icons.

@calexity
Copy link
Contributor

Is this along the lines of what you were thinking @magsout @karlcow @miketaylr?

commentstatus

@karlcow
Copy link
Member

karlcow commented Jan 11, 2015

Yes something like this. That's cool.
I would put either icon or text but not both for the status.

@calexity
Copy link
Contributor

In that case, I think the text is clearer. I'd drop the icon at least until we've had them for a while.

@magsout
Copy link
Member Author

magsout commented Jan 30, 2015

A tooltip or title perhaps? I am concerned if we add the title of issue in the middle of the sentence, becomes difficult to understand, especially if we just add a reference

@karlcow
Copy link
Member

karlcow commented Jan 31, 2015

@magsout yes. good grief, it can be overloaded. Let's imagine how these could be manipulated, changed, etc. The question is more about, how do we want it. :)

Another way of doing it (layout can be changed, just illustrating the concept):

capture d ecran 2015-01-31 a 09 55 19

Could become something like:

capture d ecran 2015-01-31 a 09 55 01

@magsout
Copy link
Member Author

magsout commented Jan 31, 2015

I like the second 👍

@karlcow
Copy link
Member

karlcow commented Feb 2, 2015

Note that this is just exploration. I really think we can do better. Any suggestions are welcome. :)

@calexity
Copy link
Contributor

I love the tooltip idea! Though it wouldn't work on mobile.

Something like this
http://cssdeck.com/labs/pure-css-tooltip-with-arrow

@miketaylr
Copy link
Member

  • add marked.js fork to our repo
  • implement issue parsing

@miketaylr
Copy link
Member

After doing some investigating, it seems Marked.js is very buggy and hacking support for this might be not worth it. Right now emoji and @username stuff only works if it's the only item of a block/paragraph. https://github.com/markdown-it/markdown-it looks promising and has a nice plugin architecture, already with emoji plugin and a "hashtag" plugin that could be extended for issue linking.

@miketaylr
Copy link
Member

Let's take care of #604 then we can properly do this.

@karlcow
Copy link
Member

karlcow commented Aug 11, 2015

#604 is done. Where do we stand on this one for @usernames and #numbers?

@miketaylr
Copy link
Member

cc @hallvors who is going to be learning the markdown parser for #716

@hallvors
Copy link
Contributor

hallvors commented Oct 1, 2015

'k, if you want more fancy stuff here please file new bugs..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants