-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue comment - Parse hashtag on comment #501
Comments
yes good point and plus I think we could make it better than GitHub. Let's not just implement the github feature.
|
Good suggestions. I should also probably add our fork of marked.js to the repo as well. Adding needs-design label for status icons. |
Is this along the lines of what you were thinking @magsout @karlcow @miketaylr? |
Yes something like this. That's cool. |
In that case, I think the text is clearer. I'd drop the icon at least until we've had them for a while. |
A tooltip or title perhaps? I am concerned if we add the title of issue in the middle of the sentence, becomes difficult to understand, especially if we just add a reference |
@magsout yes. good grief, it can be overloaded. Let's imagine how these could be manipulated, changed, etc. The question is more about, how do we want it. :) Another way of doing it (layout can be changed, just illustrating the concept): Could become something like: |
I like the second 👍 |
Note that this is just exploration. I really think we can do better. Any suggestions are welcome. :) |
I love the tooltip idea! Though it wouldn't work on mobile. Something like this |
|
After doing some investigating, it seems Marked.js is very buggy and hacking support for this might be not worth it. Right now emoji and @username stuff only works if it's the only item of a block/paragraph. https://github.com/markdown-it/markdown-it looks promising and has a nice plugin architecture, already with emoji plugin and a "hashtag" plugin that could be extended for issue linking. |
Let's take care of #604 then we can properly do this. |
#604 is done. Where do we stand on this one for |
'k, if you want more fancy stuff here please file new bugs.. |
Like
![capture d ecran 2014-12-20 a 11 06 24](https://cloud.githubusercontent.com/assets/1997108/5514471/4b2a9b52-8838-11e4-8c9c-a6699ec5c5a9.png)
I have to go on Github to see the correct issue.
The text was updated successfully, but these errors were encountered: