Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] nosetests should not be run with python run.py -t #2567

Closed
karlcow opened this issue Aug 9, 2018 · 1 comment
Closed

[travis] nosetests should not be run with python run.py -t #2567

karlcow opened this issue Aug 9, 2018 · 1 comment

Comments

@karlcow
Copy link
Member

karlcow commented Aug 9, 2018

Following the discussion in #2518 (comment)

At any rate, you're right, of course -- it's not that nosetests kicks run.py directly... it's that in Travis we always execute run.py -t before we run nosetests (or, rather, all the test scripts). (At least digging into all this, I learned a bunch of stuff about our configuration! (-; )

This should not happen. It's a "bug".

We should start python run.py -t after nosetests has run.

@karlcow
Copy link
Member Author

karlcow commented Aug 9, 2018

Relevant section

install:
- travis_retry npm install
- travis_retry npm run pip
- travis_retry npm run config
- which firefox
- java -version
- firefox --version
# lint python
- pep8 --ignore=E402 webcompat/ tests/ config/secrets.py.example
- python run.py -t &
before_script:
- sleep 5
# lint JS in default eslint task
- npm run lint
- npm run build
# now run the tests!
script:
- nosetests
- sleep 5
- npm run test:js -- --reporters="runner" --firefoxBinary=`which firefox`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant