You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🐝 10:07:14 ~/code/webcompat.com
→ python run.py
Statuses Initialization…
Fetching milestones from Github…
Milestones are not initialized. Check logs.
Our current logic is to try to fetch the milestones online, and if it the network request fails to fallback on the data/milestones.json. This has consequences.
The project can't start if the user is offline even with the right data.
The project can't start if the GitHub API received already too many requests and data/milestones.json doesn't already exist. (This happened during All Hands.)
We could invert the logic by checking first data/milestones.json and fetching online if it doesn't exist. It would be more logical at least in LOCALHOST mode where we have probably a version of the data handy. The frequency of actions seem to be in favor of data/ first and then network second.
We could invert the logic by checking first data/milestones.json and fetching online if it doesn't exist. It would be more logical at least in LOCALHOST mode where we have probably a version of the data handy.
Steps to reproduce:
Actual:
Our current logic is to try to fetch the milestones online, and if it the network request fails to fallback on the data/milestones.json. This has consequences.
We could invert the logic by checking first data/milestones.json and fetching online if it doesn't exist. It would be more logical at least in LOCALHOST mode where we have probably a version of the data handy. The frequency of actions seem to be in favor of data/ first and then network second.
This would partially solves #2518
@miketaylr for input/feedback
The text was updated successfully, but these errors were encountered: