Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the prettier version to specific version #1548

Closed
magsout opened this issue May 3, 2017 · 4 comments
Closed

Pin the prettier version to specific version #1548

magsout opened this issue May 3, 2017 · 4 comments

Comments

@magsout
Copy link
Member

magsout commented May 3, 2017

I think it would be necessary to block the prettier version in package.json to avoid errors like here #1538 (comment)

The error is caused by a different version in the package.json. So every time we install prettier, or update all nodes module, we can cause an new error if there is a new update.

@miketaylr
Copy link
Member

@magsout what do you mean by block?

https://github.com/webcompat/webcompat.com/blob/master/package.json#L43 has ^1.1.0 -- do you mean we pin to exactly a single version, so just 1.1.0?

@magsout
Copy link
Member Author

magsout commented May 3, 2017

@miketaylr yes exactly.

@miketaylr miketaylr changed the title Blocked the prettier version to avoid errors Pin the prettier version to specific version May 3, 2017
@miketaylr
Copy link
Member

Cool, +1.

magsout added a commit that referenced this issue May 19, 2017
magsout added a commit that referenced this issue Jun 6, 2017
@zoepage
Copy link
Member

zoepage commented Jun 12, 2017

Fixed in 182e77a

@zoepage zoepage closed this as completed Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants