Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run.py doesn't handle properly missing BACKUP_DEFAULT_DEST #1294

Closed
karlcow opened this issue Jan 19, 2017 · 1 comment
Closed

run.py doesn't handle properly missing BACKUP_DEFAULT_DEST #1294

karlcow opened this issue Jan 19, 2017 · 1 comment

Comments

@karlcow
Copy link
Member

karlcow commented Jan 19, 2017 

→ python run.py --backup
('secrets', '/Users/karl/code/webcompat.com')
Traceback (most recent call last):
  File "run.py", line 125, in <module>
    if not os.path.exists(app.config['BACKUP_DEFAULT_DEST']):
KeyError: 'BACKUP_DEFAULT_DEST'

Also there is a big cleanup to do for the syntax, lines too long, etc.
@karlcow karlcow mentioned this issue Jan 19, 2017
Merged
MDTsai added a commit to MDTsai/webcompat.com that referenced this issue Jan 25, 2017
@MDTsai
Issue webcompat#1161 - Print message if there is nothing to backup
476c317 
Follow-up of issue webcompat#1157, print message if there is nothing to backup
to BACKUP_DEFAULT_DEST

Issue webcompat#1294 - Check BAKCUP_DEFAULT_DEST before backup

Also fix the syntax, no warning using PEP8 check.
MDTsai added a commit to MDTsai/webcompat.com that referenced this issue Jan 25, 2017
@MDTsai
Issue webcompat#1161 - Print message if there is nothing to backup
2dc98f2 
Follow-up of issue webcompat#1157, print message if there is nothing to backup
to BACKUP_DEFAULT_DEST

Issue webcompat#1294 - Check BAKCUP_DEFAULT_DEST before backup

Also fix the syntax, no warning using PEP8 check.
MDTsai added a commit to MDTsai/webcompat.com that referenced this issue Jan 25, 2017
@MDTsai
Issue webcompat#1161 - Print message if there is nothing to backup
fb21fd6 
Follow-up of issue webcompat#1157, print message if there is nothing to backup
to BACKUP_DEFAULT_DEST

Issue webcompat#1294 - Check BAKCUP_DEFAULT_DEST before backup

Also fix the syntax, no warning using PEP8 check.
MDTsai added a commit to MDTsai/webcompat.com that referenced this issue Jan 25, 2017
@MDTsai
Issue webcompat#1161 - Print message if there is nothing to backup
04c30df 
Follow-up of issue webcompat#1157, print message if there is nothing to backup
to BACKUP_DEFAULT_DEST

Issue webcompat#1294 - Check BAKCUP_DEFAULT_DEST before backup

Also fix the syntax, no warning using PEP8 check.
@karlcow
Copy link
Member Author

karlcow commented Jan 25, 2017

This has been addressed by @MDTsai on #1291
Closing. Thanks!

@karlcow karlcow closed this as completed Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @karlcow