Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle comment pagination on the server side #1058

Closed
miketaylr opened this issue May 20, 2016 · 1 comment
Closed

Handle comment pagination on the server side #1058

miketaylr opened this issue May 20, 2016 · 1 comment
Assignees
@miketaylr

Comments

@miketaylr
Copy link
Member

miketaylr commented May 20, 2016 •
edited
Loading

See point 1 from #1044 (comment).

Basic idea is to request and lump together comments until rel=last if we detect that there are more than 1 page of comments.

Once we have this we can remove the hack from #1044.
@miketaylr miketaylr mentioned this issue May 20, 2016
Merged
deepthivenkat added a commit that referenced this issue Jun 23, 2016
@deepthivenkat
Issue #1058 - Added code for fetch first page(30 Issues) and render, …
30e0d4a 
…fetch remaining issues and render
deepthivenkat added a commit that referenced this issue Jun 24, 2016
@deepthivenkat
Issue #1058 - Added code for fetch first page(30 Issues) and render, …
30671d6 
…fetch remaining issues and render
deepthivenkat added a commit to deepthivenkat/webcompat.com that referenced this issue Jul 6, 2016
@deepthivenkat
Issue webcompat#1058 - Fetching and rendering all comments
a84ede1
deepthivenkat added a commit to deepthivenkat/webcompat.com that referenced this issue Jul 13, 2016
@deepthivenkat
Issue webcompat#1058 - Code clean up. Renaming variables. Incorporate…
7872305 
… review comments
miketaylr pushed a commit that referenced this issue Jul 28, 2016
Revert "Fixes #1058 - Fetching and rendering all comments"
d45947e
@miketaylr miketaylr self-assigned this Jul 28, 2016
miketaylr pushed a commit that referenced this issue Jul 28, 2016
Merge pull request #1144 from webcompat/revert-1119-issues/1058/1
559cb60 
Revert "Fixes #1058 - Fetching and rendering all comments"
@miketaylr miketaylr reopened this Jul 28, 2016
@miketaylr miketaylr mentioned this issue Jul 28, 2016
Closed
@miketaylr
Copy link
Member Author

Re-opening because something changed and it broke all comments on the site.

We need tests to cover the scenario where GitHub sends a Link Header and doesn't. And probably tests for when GitHub might send a malformed/broken Link Header.

deepthivenkat added a commit to deepthivenkat/webcompat.com that referenced this issue Jul 29, 2016
@deepthivenkat
Issue webcompat#1058 - Link header changes when comments per issue is…
d818d0e 
… less than 30
deepthivenkat added a commit to deepthivenkat/webcompat.com that referenced this issue Jul 29, 2016
@deepthivenkat
Issue webcompat#1058 - Link header changes when comments per issue is…
e66b87b 
… less than 30
deepthivenkat added a commit to deepthivenkat/webcompat.com that referenced this issue Jul 29, 2016
@deepthivenkat
Issue webcompat#1058 - Tests to check link header in response for git…
b1b59af 
…hub api /issues/<issue_number>/comments
@miketaylr miketaylr mentioned this issue Jul 29, 2016
Merged
deepthivenkat added a commit to deepthivenkat/webcompat.com that referenced this issue Aug 1, 2016
@deepthivenkat
Issue webcompat#1058 - removing ternary operation, making eslint styl…
dcd08cf 
…e changes
deepthivenkat added a commit to deepthivenkat/webcompat.com that referenced this issue Aug 1, 2016
@deepthivenkat
Issue webcompat#1058 - Group and render all the comments for an issue…
43c81ce 
…. Place checks for empty link header
deepthivenkat added a commit to deepthivenkat/webcompat.com that referenced this issue Aug 1, 2016
@deepthivenkat
Issue webcompat#1058 - Tests to check link header in response for git…
385ddad 
…hub api /issues/<issue_number>/comments
deepthivenkat added a commit to deepthivenkat/webcompat.com that referenced this issue Aug 1, 2016
@deepthivenkat
Issue webcompat#1058 - Removing ternary operation, making eslint styl…
2924854 
…e changes.
deepthivenkat added a commit to deepthivenkat/webcompat.com that referenced this issue Aug 1, 2016
@deepthivenkat
Issue webcompat#1058 - Removing ternary operation, making eslint styl…
51748e4 
…e changes, adding comments for test case.
miketaylr pushed a commit that referenced this issue Aug 1, 2016
Issue #1058. pep8 fixes to unbreak build. r=me
268596f
@karlcow karlcow mentioned this issue Aug 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miketaylr @karlcow @deepthivenkat