Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind API is bad #3671

Closed
wants to merge 2 commits into from
Closed

Wind API is bad #3671

wants to merge 2 commits into from

Conversation

tcm390
Copy link
Contributor

@tcm390 tcm390 commented Aug 28, 2022

Can we just set winds array in metaversefile-api.js like mirrors?

related: #3669

result:

Webaverse.-.Google.Chrome.2022-08-28.15-32-32.mp4

@avaer
Copy link
Contributor

avaer commented Aug 30, 2022

This isn't really an improvement. If the wind is controllable it should not have bare methods like setWinds. If anything it should go through a manager like everything else.

useEnvironmentManager?

@tcm390
Copy link
Contributor Author

tcm390 commented Aug 30, 2022

Closed. Handle this issue by this PR: #3673

@tcm390 tcm390 closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants