-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong physical speed and animations jitter in low fps issues ( Make them "frame rate independent" ). ( 2nd try ) #3648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avaer Kazmer <[email protected]>
Close in favor of https://github.com/upstreet-labs/app/pull/26 |
rondoor encountered this issue on webaverse/app, so reopened it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Follow this reverted PR: #3422
avatar-spriter
.To compatible with
avatar-spriter
, we can't depend onplayer
andplayer.charaterPhysics.velocity
( wich already frame rate indepedent after this PR ).So need calc
avatar.velocity
withoutplayer.charaterPhysics.velocity
.But I think we can't calc "smooth"/"frame rate independent" velocity from per frame movement/positionDiff.
So I added a
isBoundPlayer
arg to distinguish these two situations:For normal mode,
avatar.velocity
copied fromcharacterPhysics.velocity
.For spriter mode,
avatar.velocity
calced from fixed 60 fpspositionDiff
.( The velocity for
spriter
can be calced, because of the codes inavatar-spriter
are assumed always 60 fps. )app/avatars/avatars.js
Lines 1511 to 1513 in 82fa161
What are the steps for a QA tester to test this pull request?
avatar-spriter mode ( graphics low setting )
work well.Issue ticket number and link
#3422 (comment)
Screenshots and/or video
Idle animations and hair no jitter:
huddle.20220815.mp4
Compatible with spriter:
velocity.frame.rate.-.spriter.mp4
Checklist before requesting a review