Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Character blinking #3607

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Fix Character blinking #3607

merged 3 commits into from
Aug 12, 2022

Conversation

memelotsqui
Copy link
Contributor

Describe your changes

  • Added new version of scilly that has blendshapes
  • modified constant js to load the new model

What are the steps for a QA tester to test this pull request?

-load any scene, and look at scilly's eye, there shoul be blinking

Issue ticket number and link

#3424

Screenshots and/or video

2022-08-12.16-22-06.mp4

Checklist before requesting a review

  • I have performed a self-review of my code
  • I am not adding any irrelevant code or assets
  • I am only including the changes needed to implement the change
  • I have playtested and intentionally tried to find error cases but couldn't

@lalalune lalalune merged commit 17335bd into master Aug 12, 2022
@gonnavis gonnavis mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaer avaer avaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@memelotsqui @avaer @lalalune