Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npc update twice bug #3569

Closed
wants to merge 6 commits into from
Closed

npc update twice bug #3569

wants to merge 6 commits into from

Conversation

tcm390
Copy link
Contributor

@tcm390 tcm390 commented Aug 9, 2022

related:
#3565
#3397

issue:

Webaverse.-.Google.Chrome.2022-08-09.15-05-42.mp4

Result:

Webaverse.-.Google.Chrome.2022-08-09.18-51-05.mp4

@tcm390 tcm390 marked this pull request as draft August 9, 2022 18:58
@tcm390 tcm390 marked this pull request as ready for review August 11, 2022 03:11
@alisaad673
Copy link
Contributor

The previous issues seem fixed.
Just these Issues:

1-Talking to the npc is broken, throws this error:
image

2022-08-11.21-14-01.mp4

2-If we are in sonic boom and switch to npc the main character stays in the state of naruto run, same if we are in naruto run with npc and we switch to main player, the npc remains in the state of naruto run(standing)

2022-08-11.21-16-52.mp4

} */
}
};
world.appManager.addEventListener('frame', frame);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this was moved I think the npc will crash when deleted from the scene.

Copy link
Contributor

@avaer avaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole approach needs a rethink.

@avaer avaer closed this Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants