Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar optimizer 2 [WIP] #3409

Closed
wants to merge 63 commits into from
Closed

Avatar optimizer 2 [WIP] #3409

wants to merge 63 commits into from

Conversation

avaer
Copy link
Contributor

@avaer avaer commented Jul 29, 2022

Replaces #2805

Requires webaverse/totum#118

@avaer
Copy link
Contributor Author

avaer commented Jul 29, 2022

Had to import a new version of https://github.com/mrdoob/three.js/blob/dev/examples/jsm/exporters/GLTFExporter.js to get this to work; the one linked in the repo creates zero vertices for no reason.

@avaer avaer closed this Jul 29, 2022
@avaer avaer reopened this Jul 29, 2022
@avaer
Copy link
Contributor Author

avaer commented Jul 29, 2022

This replicates the merge from https://github.com/mrdoob/three.js/blob/e22cb060cc91283d250e704f886528e1be593f45/examples/jsm/utils/BufferGeometryUtils.js#L115.

However the morph attributes on the multi-geometry fold still do not align (moth morph gets set on the hair).

Note that the previous atlas merge code was also erroneous and has the same problem.

@avaer
Copy link
Contributor Author

avaer commented Jul 29, 2022

image

@avaer
Copy link
Contributor Author

avaer commented Jul 29, 2022

image

@avaer
Copy link
Contributor Author

avaer commented Aug 10, 2022

#3577

@avaer avaer closed this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant