Integrate heal effect2 #2967
Merged
Integrate heal effect2 #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaer
reviewed
May 10, 2022
character-fx.js
Outdated
| if (!this.healEffect ) { | ||
| this.healEffect = metaversefile.createApp(); | ||
| (async () => { | ||
| await metaverseModules.waitForLoad(); |
There was a problem hiding this comment.
IMO we should not wait for this here. By the time this code runs, wevaverse.js should already have waited for everything we need.
The list of all of the loads is here:
Line 79 in 77f5173
This comment also applies to the rest of the character fx meshes which have a similar code pattern.
There was a problem hiding this comment.
Also, instead, of on the first frame, we can create this app the first time it is needed, when the character first gets a heal/cure action.
Since the module is preloaded, it should be ready to go when we hit this code path so there should not be any loading delay.
avaer
reviewed
May 10, 2022
avaer
approved these changes
May 11, 2022
lalalune
pushed a commit
to TheNexusCity/webaverse-app
that referenced
this pull request
Jun 9, 2022
Integrate heal effect2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate heal effect