Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dual Contouring LOD #2930

Merged
merged 2 commits into from
May 20, 2022
Merged

Dual Contouring LOD #2930

merged 2 commits into from
May 20, 2022

Conversation

arya3d
Copy link
Contributor

@arya3d arya3d commented May 1, 2022

This is the sibling PR of this : webaverse/app-wasm#50

@arya3d arya3d requested a review from avaer May 1, 2022 06:39
@avaer
Copy link
Contributor

avaer commented May 10, 2022

This looks good, and I would like to merge this, but two problems:

  • Needs WASM rebuild (the upstream needs a rebuild too)
  • app-wasm is floating incompatible changes with app right now, since that is used in https://github.com/webaverse/app/tree/z-targeting, a PR which contains a lot of other things and is not easily broken up. So that means this PR is probably waiting behind that branch

@avaer avaer merged commit 703a797 into master May 20, 2022
@arya3d arya3d linked an issue May 26, 2022 that may be closed by this pull request
Dual Contouring : Generate Terrain With Sharp Features #2826
Closed
17 tasks
lalalune pushed a commit to TheNexusCity/webaverse-app that referenced this pull request Jun 9, 2022
Merge pull request webaverse#2930 from webaverse/dual-contouring-lod
c01cb1f 
Dual Contouring LOD
@alisaad673 alisaad673 mentioned this pull request Mar 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaer avaer avaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dual Contouring : Generate Terrain With Sharp Features
2 participants
@arya3d @avaer