Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt voice and mouth movement #2835

Merged
merged 22 commits into from
Apr 22, 2022
Merged

Grunt voice and mouth movement #2835

merged 22 commits into from
Apr 22, 2022

Conversation

tcm390
Copy link
Contributor

@tcm390 tcm390 commented Apr 18, 2022

  1. Upload 2 new sounds. (eating and drinking sound without the click at the end now)
  2. Load 'actionFiles' and 'voiceActor' in voice-pack-voicer.js so that we can access actionFiles and voiceActor name from localPlayer.
  3. Add a function call 'playGrunt' in character-sfx.js, it would load the voice from 'localPlayer.voicePack.actionFiles', and play the voice pack by 'localPlayer.voicePack.audioBuffer'. So in totum app, we could play the grunt like this localPlayer.characterSfx.playGrunt('angry', index);
  4. Add jump grunt and gasp grunt in character-sfx.js by using exponential falloff selection
    This is the jump result (each character has 6 jump grunt)
AndrewJump.mp4
bryceJump.mp4
griffinJump.mp4
shishiJump.mp4
TiffanyJump.mp4
  1. This is the gasp result (each character has 7 gasp grunt)
andrewGasp.mp4
bryceGasp.2.mp4
griffingasp.2.mp4
shishiGasp.2.mp4
tiffanyGasp.mp4
  1. Add mouth movement function in avatar.js. So we can control the mouth movement manually by this.player.avatar.setMouthMoving(attack, decay, sustain, release);, It would move the mouth according to the envelope
  2. control mouth movement for eating and drinking in character-sfx.js by using envelope. This is the result:
eatanddrink.mp4

@2-A-M
Copy link
Contributor

2-A-M commented Apr 18, 2022

1 - Gasps/pants being played after running to display that the character is tired. We have a great variety of types of gasps/pants between the 5 voice actors. Shishi and Griffin are the most "standard" type of gasp/pant, the other ones have their own characteristics. Having a variety of characteristics for the grunt is great because we can cover a bigger amount of preferences among the players.

2 - Jumps are using a selection of Attack Grunts to display the character is doing some sort of effort, attack grunts were used because they fit well on this action and we had a good amount of them to "spare". The ones used on jump will not be used on attack action to avoid audio duplicates (in case both actions are executed at the same time)

3 - For eat and drink a single sample was used for each of them. I went on this direction because it adds consistency to the action. The sample alone sounded dull, so I changed it's pitch 2 semitones up and 2 semitones down for the 2 actions, a total of 3 samples for each action.

character-sfx.js Outdated Show resolved Hide resolved
character-sfx.js Outdated Show resolved Hide resolved
avatars/avatars.js Outdated Show resolved Hide resolved
Copy link
Contributor

@avaer avaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall, but I think we need to move the code into better locations.

@alisaad673
Copy link
Contributor

alisaad673 commented Apr 19, 2022

1-The voicer gives an error while we haven't selected a voice endpoint. It works fine in the master.

image

bandicam.2022-04-19.21-58-26-978.mp4

2- The sound for jump seems to work fine, But with the case of dash "shift+double W" the jump sound doesn't plays.

bandicam.2022-04-19.21-26-32-272.mp4

3-Similarly, sound for gasp doesn't plays with dash.

bandicam.2022-04-19.21-29-18-221.mp4

4-We are not doing gasp sound on walk right?? This is being played on run only?

Else looks and sounds fine. the mouth movement seems in sync with sfx.

@tcm390
Copy link
Contributor Author

tcm390 commented Apr 19, 2022

Hi @alisaad673
For 1, I fix it. Could you test it again?
For 2, 3, 4, @Arthur-Acha could you reply these?

@alisaad673
Copy link
Contributor

Yep 1 is fixed now.

@2-A-M
Copy link
Contributor

2-A-M commented Apr 20, 2022

Hi @alisaad673 For 1, I fix it. Could you test it again? For 2, 3, 4, @Arthur-Acha could you reply these?

I think you have a good point and thanks for sharing it @alisaad673 , we should implement both gasps and jumps during and after the naruto run, but there will be a VO that will be played when you start naruto run (shit+double W), so regular jump VOs should only be able to be played after the naruto run VO ends, this way we don't have conflict with both files playing at the same time
@tcm390 can you implement this?

character-sfx.js Outdated Show resolved Hide resolved
character-behavior.js Outdated Show resolved Hide resolved
Copy link
Contributor

@avaer avaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommending a lot of code cleanups.

@tcm390
Copy link
Contributor Author

tcm390 commented Apr 21, 2022

code cleanups: 3f4cfa0

avatars/avatars.js Outdated Show resolved Hide resolved
character-sfx.js Outdated Show resolved Hide resolved
character-sfx.js Outdated Show resolved Hide resolved
Copy link
Contributor

@avaer avaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants