Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Scene with configurable camera #2088

Merged
merged 9 commits into from
Dec 31, 2021
Merged

Conversation

Sirahi
Copy link
Contributor

@Sirahi Sirahi commented Dec 27, 2021

User can now add post scene with ortho or perspective camera in application/rendersettings
{
"type": "application/rendersettings",
"content": {
"postPostProcessScene": {
"perspectiveScene": false,
"orthographicScene": true
}
}
}

Verified

This commit was signed with the committer’s verified signature.
fiji-flo Florian Dieminger

Verified

This commit was signed with the committer’s verified signature.
caugner Claas Augner
world.js Outdated
@@ -301,8 +301,11 @@ const _getBindSceneForRenderPriority = renderPriority => {
case 'low': {
return sceneLowPriority;
}
case 'postScene': {
return postScene;
case 'perspectiveScene': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be renamed to postPerspectiveScene and similar, to indicate its actual order.

@avaer
Copy link
Contributor

avaer commented Dec 30, 2021

Makes sense but recommend a small rename in the API.

@Sirahi Sirahi requested a review from avaer December 31, 2021 11:30
@avaer avaer merged commit e40b13d into webaverse:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants