MetaMask + Discord integration - with Weba-Wallet #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaer
reviewed
Nov 9, 2021
avaer
suggested changes
Nov 9, 2021
mujabmuneeb
changed the title
mujabmuneeb
changed the title
It is now being handled by weba-wallet. |
Added description and updated Title. |
utf94
force-pushed
the
discord-integration-a
branch
from
2e7ebe5 to
498fec3
Compare
avaer
reviewed
Nov 30, 2021
| else { | ||
| fetchWalletData('privateKey'); | ||
| } | ||
| }, [address, setAddress]); |
There was a problem hiding this comment.
I think this setAddress is probably pointless?
There was a problem hiding this comment.
Actually never mind, I can see how the way the code is structured it could be needed!
avaer
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Login modal with two buttons, MetaMask, and Discord respectively.
Integrated Discord Login
Integrated Weba-Wallet storage module.
Flow:
When the user logs in, App calls the setAddress setter to set the user's address and sendDataToWallet function to save the user's privateKey in Weba-wallet secure storage.
sendDataToWallet function opens hidden iframe and sends postMessage to weba-wallet along with user's privateKey.
Weba-wallet validates the app's origin receives privateKey, encrypts it, and saves it in localStorage.
For the next time, the user doesn't have to login again because on login App will request Weba-wallet for the user's privateKey using fetchWalletData('privateKey').
If Weba-Wallet validates App origin, it will decrypt privateKey and returns it. And by using that privateKey, App will fetch the user's address and set it.
Flow Diagram