Multiplayer!

[AGoblinKing]

• Enables integration with github.com/webaverse/dialog for multiplayer poses
• Uses the eslint-prettier autoformatter, let me know if you don't like any of the styles and we can update the options

Depends on webaverse/dialog#7

[AGoblinKing]

Well back to draft, trying out a better way of doing the hashHost passing

[avaer]

Uses the eslint-prettier autoformatter, let me know if you don't like any of the styles and we can update the options
I don't think it's consistent with the ESLint rules, but also: I don't think this is the PR to do it.

We should do a full pass over to code to pretty it to either eslint or prettier, but we shouldn't keep multiple formats and format types, and we shouldn't make that change in an unrelated PR.

[AGoblinKing]

I can take the linter out and undo any of its funkier changes. This should be enforcing the existing style guide though, so no file should change if it meets the lint requirements.

[avaer]

This should be enforcing the existing style guide though

Ah you're right, I'll clean up the eslint rules because they are not quite what I think we've been using for the code.

[AGoblinKing]

I took prettier out. Should I revert those style changes to the files touched or keep them? My linter is mad at me with the old stuff per your reply.

[AGoblinKing]

for comparison

[avaer]

I took prettier out. Should I revert those style changes to the files touched or keep them? My linter is mad at me with the old stuff per your reply.

Yeah we should fix that but not in this issue.

[avaer]

One particularly nasty rule is the casing of hex literals, which are usually pasted from other tools and lists that we do not want munged by the prettier.

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/number-literal-case.md fails to mention what option to enable and to what value.

[AGoblinKing]

I use .prettierignore to avoid munging third party libraries. Lets talk about the style in another CL. I can revert the significant style changes here easily.

[avaer]

I use .prettierignore to avoid munging third party libraries.

It's not the libraries, it's the content we paste in to local source files from sources like design templates (eg constantly changing
massive colors lists)

[avaer]

I updated the .eslintrc in master to reduce the amount of code changes next time we run it.

[AGoblinKing]

Okay that should be easier to read, minus RoomClient which greatly needed some formating.

[avaer]

This would be better using a regex. We don't want to corrupt domains like robot3000.club.

[AGoblinKing]

it could affect the githubpreview.dev hostname including subdomains only which seems unlikely. We're relying on an undocumented naming convention is the bigger issue imo.

[avaer]

Keep in mind that we lose hosted rooms support with this change:

https://github.com/webaverse/app/pull/1431/files#diff-7aecd33c076eede220000d2edb73e82e0230c5fcb781bb22f8831b7e37b01b77L246

However, we can/should bring that back once we have audio working again.