Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Avatar optimizer #2805

Closed
wants to merge 53 commits into from
Closed

[WIP] Avatar optimizer #2805

wants to merge 53 commits into from

Conversation

avaer
Copy link
Contributor

@avaer avaer commented Apr 10, 2022 •
edited
Loading

Crunches all avatars by default, where the crunch does not affect the quality (same materials, redundant draw calls).

Should improve avatars performance for high quality mode.

Fixes #2788

@avaer avaer force-pushed the avatar-optimizer branch from 870cc2c to 751943d Compare April 10, 2022 23:34
@avaer avaer force-pushed the avatar-optimizer branch from 68f9212 to cf8d759 Compare April 12, 2022 15:32
@avaer
Copy link
Contributor Author

avaer commented Apr 15, 2022

This fixes #2788

@avaer
Copy link
Contributor Author

avaer commented Apr 15, 2022

The performance increase for this is about 10 FPS per each avatar in the scene (note that this is still full avatar quality).

@avaer
Copy link
Contributor Author

avaer commented Apr 26, 2022

The last thing that needs to be done here is integrating a VrmQualityManager which is responsible for shimming and generating all of the avatar proxy meshes for the 3 different avatar crunchers. This can speed up loading, too, if we use a placeholder avatar icon while avatars are loading asynchronously in the OffscreenEngine.

@avaer avaer mentioned this pull request Apr 30, 2022
Open
@avaer
Copy link
Contributor Author

avaer commented Jul 27, 2022

Resurrecting this...

@avaer avaer changed the title Avatar optimizer [WIP] Avatar optimizer Jul 28, 2022
@avaer avaer mentioned this pull request Jul 29, 2022
Closed
@lalalune lalalune closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avatars shader coalesce
2 participants
@avaer @lalalune