remove unneeded localPlayer updateds #2646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready for review, webaverse/totum#86 which this depends on is also waiting for review |
avaer
suggested changes
Mar 24, 2022
|
|
||
| transformControls.update(); | ||
| game.update(timestamp, timeDiffCapped); | ||
|
|
||
| localPlayer.updateAvatar(timestamp, timeDiffCapped); | ||
| playersManager.update(timestamp, timeDiffCapped); |
There was a problem hiding this comment.
This line is removed and not added in the Totum PR. Where did this go?
0reo
force-pushed
the
2621-performance-tracker-track-avatar-cpu
branch
from
874f523 to
dbf1c8e
Compare
0reo
force-pushed
the
2621-performance-tracker-track-avatar-cpu
branch
from
dbf1c8e to
53d02e2
Compare
avaer
suggested changes
Apr 1, 2022
|
The Totum PR has been merged but this one has not, so they are desynchronized and I suspect puling |
|
Totum PR has been reverted: webaverse/totum#86 So it will need to be submitted and merged synchronously with this one next time. |
|
new totum PR with useFrame was added to this. have not recieved any feedback regarding the review notes, but both this and totum should be ready to merge. |
0reo
force-pushed
the
2621-performance-tracker-track-avatar-cpu
branch
from
7c67767 to
1bac913
Compare
|
closing this PR as there will be a general change in approach. will be addressed in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2621
this PR removes the update code which will not be needed once the vrm templates handle that via useFrame. Currently requires webaverse/totum#97 before it can be merged