Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance tracker: track avatar CPU #2621

Open
avaer opened this issue Mar 19, 2022 · 2 comments
Open

Performance tracker: track avatar CPU #2621

avaer opened this issue Mar 19, 2022 · 2 comments
Assignees
@0reo
Milestone
Perofrmance

Comments

@avaer
Copy link
Contributor

avaer commented Mar 19, 2022 •
edited
Loading

Avatar CPU is not tracked but can easily be with a small refactor.

Right now vrm apps do not useFrame to update, but instead the update is triggered by the character controller, which is why the avatar CPU usage does not show up in the list. We need to move the player + avatar update handling to be under a useFrame call for the VRM app, which will get the avatar bones/physics CPU stats included in that app.
@avaer
Copy link
Contributor Author

avaer commented Mar 19, 2022

The work for this would build on top of #2620

@0reo
Copy link
Contributor

0reo commented Mar 21, 2022

confirming i've seen this, will address

This was referenced Mar 22, 2022
Closed
Closed
@0reo 0reo linked a pull request Mar 22, 2022 that will close this issue
remove unneeded localPlayer updateds #2646
Closed
@0reo 0reo added this to the Perofrmance milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0reo 0reo

Labels
None yet
Projects
None yet
Milestone
Perofrmance
Development

Successfully merging a pull request may close this issue.

remove unneeded localPlayer updateds webaverse/app
2 participants
@avaer @0reo