Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading jsartoolkitnft #260

Merged
merged 8 commits into from
Feb 17, 2022
Merged

Upgrading jsartoolkitnft #260

merged 8 commits into from
Feb 17, 2022

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Feb 13, 2022

Upgrading ARnft to JsartoolkitNFT version 1.0.0

Upgrading ARnft to JsartoolkitNFT version 1.0.0 with the new nulti NFT feature. The code needs to be changed we can't load a simple array of marker urls but an array of arrays. With this feature we can load more than one NFT marker in a worker, in the previous version instead we should create each worker for each NFT marker. I think this will solve some issues with mobile devices that go out of memory.
I will also make other improvements, see task list.

Task list

  • markerUrls and names should be Array<Array<string>> instead of Array<string>
  • updating examples to new code changes
  • new example arNFT_multi_one_worker_example.html
  • fix issue ratio gives NaN result ARnft-threejs#33
  • upgrading ARnft-threejs and other packages.

@kalwalt kalwalt added 🚀 enhancement New feature or request dependencies Pull requests that update a dependency file labels Feb 13, 2022
@kalwalt kalwalt self-assigned this Feb 13, 2022
@kalwalt kalwalt merged commit 50253b9 into dev Feb 17, 2022
@kalwalt kalwalt deleted the upgrading-jsartoolkitnft branch March 25, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file 🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant