Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi nft feature #12

Merged
merged 16 commits into from
Sep 24, 2021
Merged

Multi nft feature #12

merged 16 commits into from
Sep 24, 2021

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Sep 13, 2021 •
edited
Loading

This PR is linked to webarkit/ARnft#199 see comments there for more. I will update this Pr as well.
Things to fix/do:

  • in NFTaddTJS avoid to attach the scene, this should be done internally.
  • in NFTAddTJS avoid to attach a root Object3D to avoid mistakes, this also should be done internally.

@kalwalt kalwalt added the enhancement New feature or request label Sep 13, 2021
@kalwalt kalwalt self-assigned this Sep 13, 2021
@kalwalt kalwalt changed the base branch from main to dev September 13, 2021 21:19
@kalwalt kalwalt marked this pull request as draft September 15, 2021 14:54
@kalwalt kalwalt marked this pull request as ready for review September 23, 2021 19:25
@kalwalt kalwalt mentioned this pull request Sep 23, 2021
Merged
9 tasks
@kalwalt kalwalt merged commit 1c7df89 into dev Sep 24, 2021
@kalwalt kalwalt mentioned this pull request Sep 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kalwalt kalwalt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kalwalt