Improve style-namespace helper

[boris-petrov]

Fixes #5

cc @webark

As I mentioned in #5 this fixes the issue for me. Please tell me if this is completely wrong and that it should not be used like that.

[webark]

So I think this looks good. The one thing is this is still reliant on

ember-cli-styles/packages/namespace/addon/utils/process-style-type.js

Lines 18 to 20 in 4ead8b0

	owner
	.lookup('container-debug-adapter:main')
	.catalogEntriesByType(extention)

I'm not sure what the long-term support, or support in general, is for that API.

[boris-petrov]

Well, if it works on Ember 4 right now, it's going to work until at least Ember 5. 😄 We can think what to do when Ember 5 starts approaching. 😃

[webark]

hahaha!! fair point

[webark]

@boris-petrov Left a couple of comments.

Also, could we switch the commits to be conventional commits, and reference the issue number where applicable?

I haven't added a CONTRIBUTING.md yet, nor something like husky. But want to keep that format.

[webark]

Also, let's add this use case to the acceptance tests.

[boris-petrov]

@webark - I changed the commit messages, is this what you mean by "conventional commits" and reference the issue?

I don't see the comments that you've added, where is that?

Also, can you point me where exactly I should add a test? I see only "tests" in the dummy app but I'm not sure how that whole thing works.

[webark]

can you not see the three comments attached to lines of the changes in the PR?

[boris-petrov]

Nope. Perhaps try adding them again?

[webark]

weird. I just "assigned" this to you.. can you see the review comments now?

[boris-petrov]

No... can you send me a screenshot of the comments? 😄

[webark]

🤦 I had forgotten to hit submit. sorry @boris-petrov

[webark]

And for the test, you can set up a new route in the dummy app, use the differing component name, and then set up an acceptance test to verify it.

Cause that process isn't laid out currently, you could add it to the unique file name test for now, and I can split it off later..

ember-cli-styles/packages/namespace/tests/acceptance/unique-component-paths-test.js

Lines 11 to 15 in 1a536fd

	test('base rule followed', async function (assert) {
	await visit(`/unique-component-paths`);
	assert.strictEqual(this.styleFor('h1').color, 'rgb(0, 0, 14)');
	});

ember-cli-styles/packages/namespace/tests/dummy/app/router.js

Line 35 in 1a536fd

this.route('unique-component-paths');

ember-cli-styles/packages/namespace/tests/dummy/app/unique-component-paths/template.hbs

Line 1 in 1a536fd

<UniqueComponentPaths::-components::TestComponent></UniqueComponentPaths::-components::TestComponent>

ember-cli-styles/packages/namespace/tests/dummy/app/unique-component-paths/-components/test-component/template.hbs

Line 1 in 1a536fd

<div class="{{style-namespace}}">

ember-cli-styles/packages/namespace/tests/dummy/app/unique-component-paths/-components/test-component/styles.scss

Line 2 in 1a536fd

color: rgb(0, 0, 14);

this is the path of how that test is setup.

[boris-petrov]

@webark - I believe I did everything you requested! Thanks for the links for the tests - I wouldn't have figured it out on my own.

I've added a passing test and I've split the other changes in different PRs.

[webark]

@boris-petrov this has been released.

 - [email protected]
 - [email protected]
 - [email protected]

[boris-petrov]

Thank you!

[webark]

Thank you!