Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignoregaspricing config #7320

Merged
merged 7 commits into from
Oct 16, 2024
Merged

add ignoregaspricing config #7320

merged 7 commits into from
Oct 16, 2024

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Oct 11, 2024

Description

Fixes #7303
adds ignoregaspricing so contracts or sending transactions through web3.eth will not be autofill gas.

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Oct 11, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.83 kB → 641.05 kB (+225 B) +0.03%
Changeset
File Δ Size
../web3-core/lib/commonjs/web3_config.js 📈 +497 B (+2.86%) 16.96 kB → 17.44 kB
../web3-eth/lib/commonjs/utils/send_tx_helper.js 📈 +61 B (+0.66%) 9.03 kB → 9.09 kB
../web3-eth/lib/commonjs/web3_eth.js 📈 +530 B (+0.57%) 90.77 kB → 91.29 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 621.34 kB → 621.56 kB (+225 B) +0.04%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 148 B 0%
../lib/commonjs/version.d.ts 60 B 0%

@luu-alex luu-alex marked this pull request as ready for review October 11, 2024 02:55
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 7c43f75 Previous: 7008e5c Ratio
processingTx 23891 ops/sec (±6.14%) 21737 ops/sec (±7.03%) 0.91
processingContractDeploy 40543 ops/sec (±7.21%) 40986 ops/sec (±5.05%) 1.01
processingContractMethodSend 16602 ops/sec (±8.91%) 16967 ops/sec (±6.53%) 1.02
processingContractMethodCall 28424 ops/sec (±6.31%) 28544 ops/sec (±6.19%) 1.00
abiEncode 44946 ops/sec (±8.00%) 44403 ops/sec (±6.90%) 0.99
abiDecode 31480 ops/sec (±7.28%) 31413 ops/sec (±5.50%) 1.00
sign 1585 ops/sec (±0.95%) 1547 ops/sec (±3.80%) 0.98
verify 366 ops/sec (±0.79%) 369 ops/sec (±0.66%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (f701406) to head (7c43f75).
Report is 3 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7320   +/-   ##
=======================================
  Coverage   94.44%   94.45%           
=======================================
  Files         216      216           
  Lines        8463     8469    +6     
  Branches     2340     2341    +1     
=======================================
+ Hits         7993     7999    +6     
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@luu-alex
Copy link
Contributor Author

will also update docs + changelog

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luu-alex Also add e2e/integration test in web3 package for testing eth and contract package with ignore gas pricing true and false. plus in this PR need to add in docs as well.

@luu-alex luu-alex merged commit 69187c5 into 4.x Oct 16, 2024
54 checks passed
@luu-alex luu-alex deleted the add-ignoregaspricing-contract branch October 16, 2024 03:08
@luu-alex luu-alex mentioned this pull request Oct 16, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot prevent site suggested gas price in Metamask
4 participants