-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ignoregaspricing config #7320
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 7c43f75 | Previous: 7008e5c | Ratio |
---|---|---|---|
processingTx |
23891 ops/sec (±6.14% ) |
21737 ops/sec (±7.03% ) |
0.91 |
processingContractDeploy |
40543 ops/sec (±7.21% ) |
40986 ops/sec (±5.05% ) |
1.01 |
processingContractMethodSend |
16602 ops/sec (±8.91% ) |
16967 ops/sec (±6.53% ) |
1.02 |
processingContractMethodCall |
28424 ops/sec (±6.31% ) |
28544 ops/sec (±6.19% ) |
1.00 |
abiEncode |
44946 ops/sec (±8.00% ) |
44403 ops/sec (±6.90% ) |
0.99 |
abiDecode |
31480 ops/sec (±7.28% ) |
31413 ops/sec (±5.50% ) |
1.00 |
sign |
1585 ops/sec (±0.95% ) |
1547 ops/sec (±3.80% ) |
0.98 |
verify |
366 ops/sec (±0.79% ) |
369 ops/sec (±0.66% ) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7320 +/- ##
=======================================
Coverage 94.44% 94.45%
=======================================
Files 216 216
Lines 8463 8469 +6
Branches 2340 2341 +1
=======================================
+ Hits 7993 7999 +6
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
will also update docs + changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luu-alex Also add e2e/integration test in web3 package for testing eth and contract package with ignore gas pricing true and false. plus in this PR need to add in docs as well.
Description
Fixes #7303
adds ignoregaspricing so contracts or sending transactions through web3.eth will not be autofill gas.
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.