Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct type and documentation for baseFeePerGas at web3.eth.getFeeHistory #7291

Merged
merged 7 commits into from
Oct 5, 2024

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #7135

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@Muhammad-Altabba Muhammad-Altabba linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 1, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.81 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 621.32 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 313dd9b Previous: 76c468a Ratio
processingTx 21820 ops/sec (±7.17%) 21644 ops/sec (±7.51%) 0.99
processingContractDeploy 39215 ops/sec (±7.53%) 39881 ops/sec (±6.40%) 1.02
processingContractMethodSend 15581 ops/sec (±7.68%) 15939 ops/sec (±6.63%) 1.02
processingContractMethodCall 27029 ops/sec (±6.93%) 27981 ops/sec (±6.91%) 1.04
abiEncode 43884 ops/sec (±8.68%) 43956 ops/sec (±6.74%) 1.00
abiDecode 30432 ops/sec (±7.47%) 29215 ops/sec (±9.42%) 0.96
sign 1534 ops/sec (±0.73%) 1506 ops/sec (±3.35%) 0.98
verify 357 ops/sec (±0.57%) 366 ops/sec (±0.56%) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

@Muhammad-Altabba Muhammad-Altabba changed the title fix: correct type and documentation for baseFeePerGas at web3.eth.getFeeHistory [DRAFT] fix: correct type and documentation for baseFeePerGas at web3.eth.getFeeHistory Oct 1, 2024
@Muhammad-Altabba Muhammad-Altabba marked this pull request as draft October 1, 2024 10:00
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (76c468a) to head (313dd9b).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7291   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files         216      216           
  Lines        8463     8463           
  Branches     2339     2339           
=======================================
  Hits         7993     7993           
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review October 1, 2024 10:17
@Muhammad-Altabba Muhammad-Altabba changed the title [DRAFT] fix: correct type and documentation for baseFeePerGas at web3.eth.getFeeHistory fix: correct type and documentation for baseFeePerGas at web3.eth.getFeeHistory Oct 1, 2024
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, requested a small change above

@Muhammad-Altabba Muhammad-Altabba merged commit 7c207b8 into 4.x Oct 5, 2024
54 checks passed
@Muhammad-Altabba Muhammad-Altabba deleted the 7135-fix-getfeehistory-type-problem branch October 5, 2024 18:08
@luu-alex luu-alex mentioned this pull request Oct 16, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getFeeHistory type problem
3 participants