-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct type and documentation for baseFeePerGas
at web3.eth.getFeeHistory
#7291
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 313dd9b | Previous: 76c468a | Ratio |
---|---|---|---|
processingTx |
21820 ops/sec (±7.17% ) |
21644 ops/sec (±7.51% ) |
0.99 |
processingContractDeploy |
39215 ops/sec (±7.53% ) |
39881 ops/sec (±6.40% ) |
1.02 |
processingContractMethodSend |
15581 ops/sec (±7.68% ) |
15939 ops/sec (±6.63% ) |
1.02 |
processingContractMethodCall |
27029 ops/sec (±6.93% ) |
27981 ops/sec (±6.91% ) |
1.04 |
abiEncode |
43884 ops/sec (±8.68% ) |
43956 ops/sec (±6.74% ) |
1.00 |
abiDecode |
30432 ops/sec (±7.47% ) |
29215 ops/sec (±9.42% ) |
0.96 |
sign |
1534 ops/sec (±0.73% ) |
1506 ops/sec (±3.35% ) |
0.98 |
verify |
357 ops/sec (±0.57% ) |
366 ops/sec (±0.56% ) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
baseFeePerGas
at web3.eth.getFeeHistory
baseFeePerGas
at web3.eth.getFeeHistory
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7291 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 216 216
Lines 8463 8463
Branches 2339 2339
=======================================
Hits 7993 7993
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
baseFeePerGas
at web3.eth.getFeeHistory
baseFeePerGas
at web3.eth.getFeeHistory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, requested a small change above
Description
Fixes #7135
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.