-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ok/6984 update e2e network tests #7276
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 8506822 | Previous: aa471e7 | Ratio |
---|---|---|---|
processingTx |
20664 ops/sec (±7.67% ) |
21158 ops/sec (±9.13% ) |
1.02 |
processingContractDeploy |
38876 ops/sec (±5.32% ) |
39080 ops/sec (±6.04% ) |
1.01 |
processingContractMethodSend |
15090 ops/sec (±9.03% ) |
15073 ops/sec (±10.51% ) |
1.00 |
processingContractMethodCall |
27883 ops/sec (±6.40% ) |
27542 ops/sec (±6.80% ) |
0.99 |
abiEncode |
42861 ops/sec (±7.43% ) |
41986 ops/sec (±6.88% ) |
0.98 |
abiDecode |
29045 ops/sec (±8.14% ) |
29298 ops/sec (±7.95% ) |
1.01 |
sign |
1516 ops/sec (±0.81% ) |
1506 ops/sec (±0.77% ) |
0.99 |
verify |
356 ops/sec (±2.61% ) |
357 ops/sec (±3.31% ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7276 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 216 216
Lines 8463 8463
Branches 2339 2339
=======================================
Hits 7992 7992
Misses 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6984
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.