Refactor some parts of contract and accounts packages

[Muhammad-Altabba]

Description

Fixes #7196

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I ran npm run lint with success and extended the tests and types if necessary.
• I ran npm run test:unit with success.
• I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
• I ran npm run build and tested dist/web3.min.js in a browser.
• I have tested my code on the live network.
• I have checked the Deploy Preview and it looks correct.
• I have updated the CHANGELOG.md file in the root folder.
• I have linked Issue(s) with this PR in "Linked Issues" menu.

[github-actions]

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	637.83 kB → 639.24 kB (+1.41 kB)	+0.22%

Changeset

File	Δ	Size
../web3-eth-contract/lib/commonjs/contract-deployer-method-class.js	🆕 +6.91 kB	0 B → 6.91 kB
../web3-eth-accounts/lib/commonjs/tx/transactionFactory.js	📈 +286 B (+5.28%)	5.29 kB → 5.57 kB
../web3-eth-contract/lib/commonjs/index.js	📈 +71 B (+2.73%)	2.54 kB → 2.61 kB
../web3-eth-contract/lib/commonjs/contract.js	📉 -4.09 kB (-8.95%)	45.68 kB → 41.59 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
web3.min.js	618.53 kB → 619.95 kB (+1.41 kB)	+0.23%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
../lib/commonjs/index.d.ts	8.69 kB	0%
../lib/commonjs/accounts.d.ts	3.89 kB	0%
../lib/commonjs/types.d.ts	2.67 kB	0%
../lib/commonjs/web3.d.ts	1.35 kB	0%
../lib/commonjs/web3_eip6963.d.ts	1.2 kB	0%
../lib/commonjs/abi.d.ts	999 B	0%
../lib/commonjs/eth.exports.d.ts	280 B	0%
../lib/commonjs/providers.exports.d.ts	183 B	0%
../lib/commonjs/version.d.ts	60 B	0%

[github-actions]

Benchmark

Benchmark suite	Current: 744c62e	Previous: 4f8e8cc	Ratio
processingTx	21652 ops/sec (±7.80%)	21886 ops/sec (±6.09%)	1.01
processingContractDeploy	40609 ops/sec (±7.08%)	38750 ops/sec (±9.06%)	0.95
processingContractMethodSend	17382 ops/sec (±6.72%)	15198 ops/sec (±8.03%)	0.87
processingContractMethodCall	27709 ops/sec (±8.37%)	26542 ops/sec (±7.32%)	0.96
abiEncode	45812 ops/sec (±7.01%)	40956 ops/sec (±7.46%)	0.89
abiDecode	30675 ops/sec (±6.99%)	29461 ops/sec (±6.44%)	0.96
sign	1585 ops/sec (±0.81%)	1499 ops/sec (±3.97%)	0.95
verify	372 ops/sec (±0.57%)	355 ops/sec (±0.76%)	0.95

This comment was automatically generated by workflow using github-action-benchmark.

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.48%. Comparing base (6b80cf0) to head (744c62e).
Report is 17 commits behind head on 4.x.

Additional details and impacted files

@@            Coverage Diff             @@
##              4.x    #7197      +/-   ##
==========================================
+ Coverage   94.45%   94.48%   +0.02%     
==========================================
  Files         215      216       +1     
  Lines        8391     8434      +43     
  Branches     2313     2317       +4     
==========================================
+ Hits         7926     7969      +43     
  Misses        465      465              

Flag	Coverage Δ
UnitTests	94.48% <90.90%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[avkos]

I've refactored plugin a little bit. now it is not necessary to register a new transaction type. so you can make changes in this PR too

[Muhammad-Altabba]

I've refactored plugin a little bit. now it is not necessary to register a new transaction type. so you can make changes in this PR too

Thanks @avkos ,
The changes in this MR for the transaction type registration still fixes an issue that might happen if someone used the this functionality.