-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contract Transactions Middleware #7138
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 3c63d60 | Previous: 280b8f0 | Ratio |
---|---|---|---|
processingTx |
8625 ops/sec (±4.09% ) |
8643 ops/sec (±4.01% ) |
1.00 |
processingContractDeploy |
39880 ops/sec (±6.28% ) |
37706 ops/sec (±7.16% ) |
0.95 |
processingContractMethodSend |
15338 ops/sec (±7.96% ) |
15011 ops/sec (±8.43% ) |
0.98 |
processingContractMethodCall |
26490 ops/sec (±8.22% ) |
26199 ops/sec (±7.75% ) |
0.99 |
abiEncode |
41269 ops/sec (±6.92% ) |
40879 ops/sec (±7.43% ) |
0.99 |
abiDecode |
29817 ops/sec (±6.41% ) |
30556 ops/sec (±6.68% ) |
1.02 |
sign |
1490 ops/sec (±3.79% ) |
1503 ops/sec (±3.72% ) |
1.01 |
verify |
367 ops/sec (±0.78% ) |
363 ops/sec (±0.57% ) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7138 +/- ##
=======================================
Coverage 94.44% 94.45%
=======================================
Files 215 215
Lines 8366 8379 +13
Branches 2304 2310 +6
=======================================
+ Hits 7901 7914 +13
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
#7134
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.