-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zk plugin related fixes #7124
Zk plugin related fixes #7124
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 35dd584 | Previous: e9fc019 | Ratio |
---|---|---|---|
processingTx |
9142 ops/sec (±3.33% ) |
9175 ops/sec (±3.95% ) |
1.00 |
processingContractDeploy |
39843 ops/sec (±7.98% ) |
38902 ops/sec (±6.92% ) |
0.98 |
processingContractMethodSend |
15411 ops/sec (±9.17% ) |
15550 ops/sec (±7.85% ) |
1.01 |
processingContractMethodCall |
27836 ops/sec (±6.82% ) |
27222 ops/sec (±8.01% ) |
0.98 |
abiEncode |
43246 ops/sec (±9.23% ) |
43564 ops/sec (±6.49% ) |
1.01 |
abiDecode |
30823 ops/sec (±6.07% ) |
30187 ops/sec (±7.32% ) |
0.98 |
sign |
1528 ops/sec (±3.69% ) |
1545 ops/sec (±0.67% ) |
1.01 |
verify |
366 ops/sec (±0.95% ) |
367 ops/sec (±0.61% ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7124 +/- ##
==========================================
+ Coverage 93.98% 94.45% +0.46%
==========================================
Files 215 215
Lines 8335 8387 +52
Branches 2301 2313 +12
==========================================
+ Hits 7834 7922 +88
+ Misses 501 465 -36
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.