EIP 712 fixes

[avkos]

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I ran npm run lint with success and extended the tests and types if necessary.
• I ran npm run test:unit with success.
• I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
• I ran npm run build and tested dist/web3.min.js in a browser.
• I have tested my code on the live network.
• I have checked the Deploy Preview and it looks correct.
• I have updated the CHANGELOG.md file in the root folder.
• I have linked Issue(s) with this PR in "Linked Issues" menu.

[github-actions]

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	630.13 kB → 630.09 kB (-42 B)	-0.01%

Changeset

File	Δ	Size
../web3-eth-accounts/lib/commonjs/account.js	📉 -4 B (-0.01%)	30.49 kB → 30.48 kB
../web3-eth-abi/lib/commonjs/eip_712.js	📉 -6 B (-0.10%)	5.71 kB → 5.7 kB
../web3-utils/lib/commonjs/hash.js	📉 -73 B (-0.56%)	12.72 kB → 12.65 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
web3.min.js	610.84 kB → 610.8 kB (-42 B)	-0.01%

Unchanged

Asset	File Size	% Changed
../lib/commonjs/index.d.ts	8.69 kB	0%
../lib/commonjs/accounts.d.ts	3.89 kB	0%
../lib/commonjs/types.d.ts	2.67 kB	0%
../lib/commonjs/web3.d.ts	1.35 kB	0%
../lib/commonjs/web3_eip6963.d.ts	1.2 kB	0%
../lib/commonjs/abi.d.ts	999 B	0%
../lib/commonjs/eth.exports.d.ts	280 B	0%
../lib/commonjs/providers.exports.d.ts	183 B	0%
../lib/commonjs/version.d.ts	60 B	0%

[github-actions]

Benchmark

Benchmark suite	Current: 7408a3d	Previous: 16252f9	Ratio
processingTx	8950 ops/sec (±4.09%)	8718 ops/sec (±4.07%)	0.97
processingContractDeploy	39958 ops/sec (±6.44%)	38913 ops/sec (±7.29%)	0.97
processingContractMethodSend	15711 ops/sec (±9.72%)	18130 ops/sec (±7.07%)	1.15
processingContractMethodCall	28459 ops/sec (±5.72%)	36290 ops/sec (±6.10%)	1.28
abiEncode	45050 ops/sec (±7.71%)	39776 ops/sec (±7.72%)	0.88
abiDecode	30433 ops/sec (±8.60%)	28800 ops/sec (±6.54%)	0.95
sign	1529 ops/sec (±3.92%)	1530 ops/sec (±3.94%)	1.00
verify	377 ops/sec (±0.48%)	363 ops/sec (±0.60%)	0.96

This comment was automatically generated by workflow using github-action-benchmark.

[jdevcs]

LGTM, before merging unit tests should be passing

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (b552f62) to head (7408a3d).
Report is 5 commits behind head on 4.x.

Additional details and impacted files

@@            Coverage Diff             @@
##              4.x    #7095      +/-   ##
==========================================
+ Coverage   93.98%   94.75%   +0.76%     
==========================================
  Files         215      215              
  Lines        8335     8334       -1     
  Branches     2301     2296       -5     
==========================================
+ Hits         7834     7897      +63     
+ Misses        501      437      -64     

Flag	Coverage Δ
UnitTests	94.75% <100.00%> (+0.76%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
web3	∅ <ø> (∅)
web3-core	∅ <ø> (∅)
web3-errors	∅ <ø> (∅)
web3-eth	∅ <ø> (∅)
web3-eth-abi	∅ <ø> (∅)
web3-eth-accounts	∅ <ø> (∅)
web3-eth-contract	∅ <ø> (∅)
web3-eth-ens	∅ <ø> (∅)
web3-eth-iban	∅ <ø> (∅)
web3-eth-personal	∅ <ø> (∅)
web3-net	∅ <ø> (∅)
web3-providers-http	∅ <ø> (∅)
web3-providers-ipc	∅ <ø> (∅)
web3-providers-ws	∅ <ø> (∅)
web3-rpc-methods	∅ <ø> (∅)
web3-utils	∅ <ø> (∅)
web3-validator	∅ <ø> (∅)