fix(docs): contracts-tutorial #7084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danforbes
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 5d9e570 | Previous: 7af8090 | Ratio |
|---|---|---|---|
processingTx |
8908 ops/sec (±4.70%) |
9348 ops/sec (±3.97%) |
1.05 |
processingContractDeploy |
37386 ops/sec (±6.44%) |
40452 ops/sec (±6.63%) |
1.08 |
processingContractMethodSend |
18675 ops/sec (±7.77%) |
19668 ops/sec (±6.95%) |
1.05 |
processingContractMethodCall |
39727 ops/sec (±5.62%) |
37823 ops/sec (±6.19%) |
0.95 |
abiEncode |
43099 ops/sec (±7.06%) |
44665 ops/sec (±7.08%) |
1.04 |
abiDecode |
29962 ops/sec (±7.89%) |
30295 ops/sec (±7.99%) |
1.01 |
sign |
1538 ops/sec (±3.17%) |
1584 ops/sec (±0.73%) |
1.03 |
verify |
374 ops/sec (±0.57%) |
371 ops/sec (±2.86%) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7084 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 215 215
Lines 8335 8335
Branches 2301 2301
=======================================
Hits 7834 7834
Misses 501 501
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jdevcs
approved these changes
Jun 10, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the smart contracts tutorial was unnecessarily complicated by the use of the Web3.js plugin for Hardhat so I amended the tutorial to only use the Hardhat node and not use the plugin.