Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): formatting #7072

Merged
merged 2 commits into from
Jun 4, 2024
Merged

chore(docs): formatting #7072

merged 2 commits into from
Jun 4, 2024

Conversation

danforbes
Copy link
Contributor

Formatting fixes for recently updated pages

  • Titles/headings should use proper capitalization
  • code comments should have leading space

@danforbes danforbes requested a review from SantiagoDevRel May 30, 2024 15:02
@danforbes danforbes marked this pull request as ready for review May 30, 2024 15:02
Copy link

github-actions bot commented May 30, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 630.32 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 611.03 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: f76d955 Previous: 8f62749 Ratio
processingTx 8663 ops/sec (±4.14%) 8813 ops/sec (±4.63%) 1.02
processingContractDeploy 37919 ops/sec (±6.76%) 35202 ops/sec (±8.08%) 0.93
processingContractMethodSend 18007 ops/sec (±6.53%) 17884 ops/sec (±5.35%) 0.99
processingContractMethodCall 37292 ops/sec (±3.88%) 34262 ops/sec (±7.43%) 0.92
abiEncode 41323 ops/sec (±8.76%) 38844 ops/sec (±8.37%) 0.94
abiDecode 30876 ops/sec (±5.78%) 26526 ops/sec (±8.50%) 0.86
sign 1493 ops/sec (±4.00%) 1546 ops/sec (±0.88%) 1.04
verify 367 ops/sec (±0.57%) 353 ops/sec (±0.78%) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.98%. Comparing base (4358140) to head (f76d955).
Report is 259 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7072      +/-   ##
==========================================
+ Coverage   87.37%   93.98%   +6.61%     
==========================================
  Files         197      215      +18     
  Lines        7548     8335     +787     
  Branches     2059     2301     +242     
==========================================
+ Hits         6595     7834    +1239     
+ Misses        953      501     -452     
Flag Coverage Δ
UnitTests 93.98% <ø> (+6.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants