Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): sidebar #7063

Merged
merged 4 commits into from
May 30, 2024
Merged

fix(docs): sidebar #7063

merged 4 commits into from
May 30, 2024

Conversation

danforbes
Copy link
Contributor

Reorganize sidebar:

  • "Connecting to MetaMask" has been moved from "Getting Started" to "Wallets and Accounts"
  • "WalletConnect Tutorial" has been moved from a top-level item to a sub-item of "Wallets and Accounts"
  • New order:
    • Getting Started
    • Providers
    • Wallets and Accounts
    • Smart Contracts
    • Event Subscription
    • Hardhat Tutorial
    • Web3 Config
    • Web3 ETH Module
    • Web3 ENS Module
    • Web3 Utils Module
    • Advanced
    • Web3 Plugin
    • Upgrading
    • Wagmi Usage
    • Migration Guides
    • Resources & Troubleshooting
    • Feedback

Copy link

github-actions bot commented May 24, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 630.38 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 611.09 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 90c23a8 Previous: 7084665 Ratio
processingTx 9282 ops/sec (±4.31%) 9007 ops/sec (±4.09%) 0.97
processingContractDeploy 41877 ops/sec (±6.74%) 39238 ops/sec (±7.22%) 0.94
processingContractMethodSend 20280 ops/sec (±7.16%) 20030 ops/sec (±7.13%) 0.99
processingContractMethodCall 40747 ops/sec (±5.66%) 39541 ops/sec (±6.02%) 0.97
abiEncode 46165 ops/sec (±6.54%) 44070 ops/sec (±7.45%) 0.95
abiDecode 31699 ops/sec (±7.86%) 30628 ops/sec (±7.57%) 0.97
sign 1580 ops/sec (±3.27%) 1565 ops/sec (±3.15%) 0.99
verify 381 ops/sec (±0.30%) 376 ops/sec (±0.45%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (7084665) to head (fd3f199).

Current head fd3f199 differs from pull request most recent head 90c23a8

Please upload reports for the commit 90c23a8 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7063   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         215      215           
  Lines        8335     8335           
  Branches     2301     2301           
=======================================
  Hits         7683     7683           
  Misses        652      652           
Flag Coverage Δ
UnitTests 92.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danforbes
Copy link
Contributor Author

preview is not building due to link update required? https://github.com/web3/web3.js/actions/runs/9227380587/job/25389319225?pr=7063#step:7:194

Good looking out @jdevcs 🙏🏻 I've fixed the link 💯 Here is the deployment https://b7b434d7.web3-js-docs.pages.dev/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants