web3modal documentation #7041
Merged
web3modal documentation #7041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2024 16:34
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 0dd5e23 | Previous: 866469d | Ratio |
|---|---|---|---|
processingTx |
9049 ops/sec (±4.83%) |
8892 ops/sec (±3.98%) |
0.98 |
processingContractDeploy |
38278 ops/sec (±6.89%) |
38535 ops/sec (±6.62%) |
1.01 |
processingContractMethodSend |
19407 ops/sec (±5.97%) |
18875 ops/sec (±7.64%) |
0.97 |
processingContractMethodCall |
39692 ops/sec (±3.75%) |
40251 ops/sec (±5.97%) |
1.01 |
abiEncode |
42920 ops/sec (±7.11%) |
42727 ops/sec (±6.75%) |
1.00 |
abiDecode |
29980 ops/sec (±9.04%) |
29052 ops/sec (±7.20%) |
0.97 |
sign |
1590 ops/sec (±3.70%) |
1560 ops/sec (±0.80%) |
0.98 |
verify |
373 ops/sec (±0.90%) |
371 ops/sec (±0.49%) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7041 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 215 215
Lines 8291 8291
Branches 2277 2277
=======================================
Hits 7626 7626
Misses 665 665
Flags with carried forward coverage won't be shown. Click here to find out more.
|
avkos
approved these changes
May 15, 2024
jdevcs
approved these changes
May 15, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://e305244d.web3-js-docs.pages.dev/guides/web3_modal_guide/
#6749
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.