Implement a way to know which response corresponds to which request in the middleware #7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 966bdab | Previous: 88b7e2e | Ratio |
|---|---|---|---|
processingTx |
9246 ops/sec (±3.59%) |
9219 ops/sec (±3.36%) |
1.00 |
processingContractDeploy |
40412 ops/sec (±6.46%) |
38213 ops/sec (±7.03%) |
0.95 |
processingContractMethodSend |
19811 ops/sec (±7.14%) |
19245 ops/sec (±6.02%) |
0.97 |
processingContractMethodCall |
38428 ops/sec (±5.54%) |
38559 ops/sec (±4.51%) |
1.00 |
abiEncode |
43933 ops/sec (±6.93%) |
41839 ops/sec (±8.41%) |
0.95 |
abiDecode |
29798 ops/sec (±7.85%) |
30277 ops/sec (±6.54%) |
1.02 |
sign |
1591 ops/sec (±0.68%) |
1556 ops/sec (±3.30%) |
0.98 |
verify |
369 ops/sec (±2.73%) |
374 ops/sec (±0.46%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
| @@ -2448,6 +2448,10 @@ If there are any bugs, improvements, optimizations or any new feature proposal f | |||
|
|
|||
| ### Added | |||
|
|
|||
| #### web3 | |||
|
|
|||
| - Updated type `Web3EthInterface.accounts` to includes `privateKeyToAccount`,`privateKeyToAddress`,and `privateKeyToPublicKey` (#6762) | |||
There was a problem hiding this comment.
Sorry, is this the correct change for this MR?
There was a problem hiding this comment.
It was chacngelog sync fix
jdevcs
approved these changes
May 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7028 +/- ##
==========================================
+ Coverage 87.37% 91.97% +4.60%
==========================================
Files 197 215 +18
Lines 7548 8290 +742
Branches 2059 2277 +218
==========================================
+ Hits 6595 7625 +1030
+ Misses 953 665 -288
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Muhammad-Altabba
approved these changes
May 6, 2024
Muhammad-Altabba
approved these changes
May 6, 2024
avkos
deleted the
ok/7003-Implement-a-way-to-know-which-response-corresponds-to-which-request-in-the-middleware
branch
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #7003
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.