Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils guide #7001

Closed
wants to merge 30 commits into from
Closed

Utils guide #7001

wants to merge 30 commits into from

Conversation

SantiagoDevRel
Copy link

Closing issue #6742

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 623.22 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 604.16 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.45 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: b488120 Previous: 6c075db Ratio
processingTx 9144 ops/sec (±3.48%) 9301 ops/sec (±4.81%) 1.02
processingContractDeploy 40409 ops/sec (±6.22%) 39129 ops/sec (±7.62%) 0.97
processingContractMethodSend 19247 ops/sec (±6.96%) 19443 ops/sec (±5.19%) 1.01
processingContractMethodCall 39589 ops/sec (±6.65%) 38971 ops/sec (±6.34%) 0.98
abiEncode 43992 ops/sec (±6.75%) 44252 ops/sec (±6.92%) 1.01
abiDecode 30264 ops/sec (±8.11%) 30419 ops/sec (±8.89%) 1.01
sign 1594 ops/sec (±3.46%) 1656 ops/sec (±4.08%) 1.04
verify 378 ops/sec (±0.95%) 373 ops/sec (±0.78%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@luu-alex
Copy link
Contributor

Web3_Utils_module/Mastering_web3-utils.md file and folder name should be lowercase

docs/yarn.lock Outdated
@@ -9066,4 +9066,4 @@ zwitch@^1.0.0:
zwitch@^2.0.0:
version "2.0.4"
resolved "https://registry.yarnpkg.com/zwitch/-/zwitch-2.0.4.tgz#c827d4b0acb76fc3e685a4c6ec2902d51070e9d7"
integrity sha512-bXE4cR/kVZhKZX/RjPEflHaKVhUVl85noU3v6b8apfQEc1x4A+zBxjZ4lN8LqGd6WZ3dl98pY4o717VFmoPp+A==
integrity sha512-bXE4cR/kVZhKZX/RjPEflHaKVhUVl85noU3v6b8apfQEc1x4A+zBxjZ4lN8LqGd6WZ3dl98pY4o717VFmoPp+A==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock shouldn't be changed. you do not have changes in package.json. please revert it

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except comments

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 93.22034% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 91.98%. Comparing base (2373e94) to head (b488120).
Report is 23 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7001      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.02%     
==========================================
  Files         215      215              
  Lines        8172     8284     +112     
  Branches     2202     2273      +71     
==========================================
+ Hits         7518     7620     +102     
- Misses        654      664      +10     
Flag Coverage Δ
UnitTests 91.98% <93.22%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@SantiagoDevRel SantiagoDevRel mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants