Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web3-types import #6590

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Conversation

dangarbri
Copy link
Contributor

Description

Fix import

Fixes #6589

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

I did not do most of the things below because I don't have a dev environment set up for this...

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. with your fix, it will be two web3-types imports. it will be better to move the Eip712TypedData import to the previous import

import {
	Address,
	BlockNumberOrTag,
	Filter,
	HexString32Bytes,
	HexString8Bytes,
	HexStringBytes,
	TransactionCallAPI,
	TransactionWithSenderAPI,
	Uint,
	Uint256,
	Web3EthExecutionAPI,
        Eip712TypedData,
} from 'web3-types';

@dangarbri
Copy link
Contributor Author

That makes sense. I didn't even look that closely to see that there was already a 'web3-types' import

@dangarbri
Copy link
Contributor Author

I updated the PR

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dangarbri
Could you also, please, update the CHANGELOG.md at packages/web3-rpc-methods to inform about the issues fixed in this MR?

@dangarbri
Copy link
Contributor Author

I'll be able to update it later today.

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dangarbri for your contribution.
I updated the CHANGELOG.md file.

@Muhammad-Altabba Muhammad-Altabba merged commit 0dec262 into web3:4.x Nov 17, 2023
@dangarbri
Copy link
Contributor Author

Thanks, sorry I didn't get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module 'web3-types/src/eth_types' or its corresponding type declarations.
4 participants