-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi dimensional array validation issue #6435
Fix multi dimensional array validation issue #6435
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6435 +/- ##
=======================================
Coverage 89.15% 89.16%
=======================================
Files 199 199
Lines 7756 7762 +6
Branches 2147 2150 +3
=======================================
+ Hits 6915 6921 +6
Misses 841 841
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
1b73081
to
db8718c
Compare
@fullkomnun also now there is need to fix Conflicting file. thanks. |
Description
Currently for a multi-dimensional array (bounded or unbounded) that follows a sibling field (is not the first field defined in its level), extrwcted JSON scheme is missing some field.
Sample ABI
Expected JSON Scheme
Actual JSON Scheme
This is due to mishandling of multi-dimensional arrays when ABI is converted to JSON scheme leading to loss of parts of the scheme (in this case 'x1' input parameter from the ABI is discarded).
Fixed that and added a unit test payload to verify.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.