Eth personal in web3.eth #6245
Merged
Eth personal in web3.eth #6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevcs
requested review from
avkos,
luu-alex,
Muhammad-Altabba and
spacesailor24
as code owners
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6245 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 197 197
Lines 7601 7601
Branches 2083 2083
=======================================
Hits 6660 6660
Misses 941 941
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with
|
| Latest commit: |
59a20da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e3052e9d.web3-js-docs.pages.dev |
| Branch Preview URL: | https://junaid-6236ethpersonal4x.web3-js-docs.pages.dev |
avkos
approved these changes
Jun 29, 2023
Muhammad-Altabba
approved these changes
Jul 3, 2023
Co-authored-by: Muhammad Altabba <[email protected]>
Merged
sanyu1225
pushed a commit
to blocto/web3.js
that referenced
this pull request
Aug 30, 2023
* added eth personal type in web3.eth * changelog update * Update packages/web3/src/types.ts Co-authored-by: Muhammad Altabba <[email protected]> --------- Co-authored-by: Muhammad Altabba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6236
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.