-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.x - update submit work and contract.myMethod.send docs #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luu-alex
requested review from
avkos,
jdevcs,
Muhammad-Altabba and
spacesailor24
as code owners
June 26, 2023 22:44
luu-alex
added
Documentation
Relates to project wiki or documentation
1.x
1.0 related issues
labels
Jun 26, 2023
jdevcs
approved these changes
Jun 27, 2023
avkos
approved these changes
Jun 28, 2023
Muhammad-Altabba
approved these changes
Jul 3, 2023
Pull Request Test Coverage Report for Build 5465425467
💛 - Coveralls |
jdevcs
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failing CI tests in this PR should be fixed under : #6242
This was referenced Sep 4, 2023
This was referenced May 12, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5200
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
https://web3js.readthedocs.io/en/v1.7.4/web3-eth-contract.html#methods-mymethod-send
myContract.methods.myMethod([param1[, param2[, ...]]]).send(options[, callback])
should be
myContract.methods.myMethod(param1, param2,...).send(options[, callback])
and submitwork should not take in a list but
should be
web3.eth.submitWork( "0x0000000000000001", "0x1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef", "0xD1FE5700000000000000000000000000D1FE5700000000000000000000000000" )
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.