-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add util polyfill #6150
add util polyfill #6150
Conversation
Signed-off-by: Marin Petrunic <[email protected]>
Deploying with
|
Latest commit: |
d2d1a8b
|
Status: | ✅ Deploy successful! |
Preview URL: | https://290463ad.web3-js-docs.pages.dev |
Branch Preview URL: | https://add-missing-polyfill.web3-js-docs.pages.dev |
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6150 +/- ##
=======================================
Coverage 87.37% 87.37%
=======================================
Files 197 197
Lines 7548 7548
Branches 2059 2059
=======================================
Hits 6595 6595
Misses 953 953
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Can you double check if this fixs the polyfill problem? I'm still getting the error building with angular. Although seems like CRA builds work fine on 4.x main branch, not sure why. |
I tried it with CRA and it worked. Could you paste angular error and link to repo with angular repo? |
https://github.com/luu-alex/angular-web3/tree/main
|
For end users few options are, users adding explicitly in
or yarn add process
|
There is no way around it except for #6156 |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6146
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.