-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contract options fix #6118
Contract options fix #6118
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6118 +/- ##
=======================================
Coverage 87.41% 87.41%
=======================================
Files 199 199
Lines 7614 7614
Branches 2065 2065
=======================================
Hits 6656 6656
Misses 958 958
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/** | ||
* The max priority fee per gas to use for transactions. | ||
*/ | ||
maxPriorityFeePerGas?: Uint; | ||
/** | ||
* The max fee per gas to use for transactions. | ||
*/ | ||
maxFeePerGas?: Uint; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about having a consolidated type (or a base type) for ContractOptions
TransactionConfig
and any similar types like FeeMarketEIP1559TxData
, JsonTx
, NonPayableCallOptions
and TransactionCallAPI
... We may use generics because some of them use string and some use bigint or Uint8Array...
What do you think about creating an issue for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
#6119
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.