-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crc-32 and JSON ESM import fix #6049
Conversation
import goerli from './chains/goerli.json'; | ||
import mainnet from './chains/mainnet.json'; | ||
import sepolia from './chains/sepolia.json'; | ||
import goerli from './chains/goerli' ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use Static import with JSON import assertion
it solves problem for ESM only, but as it creates another issue for CJS build outputs due to current configuration settings that we have, so I converted json to ts., supporting both ESM+CJS hybrid builds in our case plus users dnt need additional --experimental-json-modules
.
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6049 +/- ##
========================================
+ Coverage 0 85.98% +85.98%
========================================
Files 0 203 +203
Lines 0 7522 +7522
Branches 0 2022 +2022
========================================
+ Hits 0 6468 +6468
- Misses 0 1054 +1054
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/common/chains/** | ||
src/common/eips/** | ||
src/common/hardforks/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring all converted json files for eslint errors as we want no to minimum changes for now in these files ( for avoiding any breaking functionality and easy maintenance of these in near future by updating these json with released eth/comon json files)
Changes to |
LGTM, just need to fix conflicts and remove the usage of buffer. think this will be fix after fixing conflicts |
some tests in geth http are failing, and will be fixed under #6060 |
Description
#6032
#6034
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.