Nikos/5835/websocket provider keeps important error message back #5884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4344683272
💛 - Coveralls |
jdevcs
reviewed
Mar 2, 2023
jdevcs
reviewed
Mar 2, 2023
jdevcs
reviewed
Mar 3, 2023
| @@ -207,7 +247,11 @@ WebsocketProvider.prototype._addSocketListeners = function () { | |||
| this.connection.addEventListener('message', this._onMessage.bind(this)); | |||
| this.connection.addEventListener('open', this._onConnect.bind(this)); | |||
| this.connection.addEventListener('close', this._onClose.bind(this)); | |||
| }; | |||
| if(this.connection._connection){ | |||
| this.connection._client.removeAllListeners('connectFailed'); //Override the internal listeners, so they don't trigger a `close` event. We want to trigger `_onClose` manually with a description. | |||
There was a problem hiding this comment.
As browsers use the native WebSocket object + doesn't use/have ws lib client and node uses ws client. so can we more specifically check _client here?
There was a problem hiding this comment.
And do we also need to handle the same for the browser WebSocket? Or is it only an issue that we need to handle just for node?
nikoulai
requested review from
Muhammad-Altabba,
jdevcs,
avkos,
luu-alex and
spacesailor24
jdevcs
approved these changes
Mar 3, 2023
…-error-message-back
nikoulai
deleted the
nikos/5835/websocket-provider-keeps-important-error-message-back
branch
Merged
This was referenced Apr 10, 2023
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #5835
Checklist for 1.x:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.