Nikos/5711/transaction with local wallet index should support to as a wallet index #5731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevcs
reviewed
Jan 6, 2023
…es" and add receiver error code as 437 This reverts commit 8e73e74.
jdevcs
reviewed
Jan 9, 2023
nikoulai
requested review from
spacesailor24,
avkos,
luu-alex and
Muhammad-Altabba
avkos
approved these changes
Jan 10, 2023
spacesailor24
suggested changes
Jan 11, 2023
packages/web3-eth/test/integration/web3_eth/send_transaction.test.ts
Outdated
Show resolved
Hide resolved
packages/web3-eth/test/integration/web3_eth/send_transaction.test.ts
Outdated
Show resolved
Hide resolved
packages/web3-types/src/eth_types.ts
Outdated
| from?: Numbers; | ||
| // eslint-disable-next-line @typescript-eslint/ban-types | ||
| to?: Address | Numbers | null; |
There was a problem hiding this comment.
to being Address | null is already handled by the type TransactionBase, so it should just be listed as Numbers here. The problem is from could be the local wallet index while to is Address | null, so I see why you did this, but it doesn't work for the inverse where to is an index but from is Address | null
I'm not sure how else to this besides introducing the following types: TransactionWithFromLocalWalletIndex, TransactionWithToLocalWalletIndex, and TransactionWithFromAndToLocalWalletIndex, so definitely open to suggestions. I've opened #5748 to implement this (doesn't update the CHANGELOGs, so that will need to be done if you decided to merge it)
…est.ts Co-authored-by: Wyatt Barnes <[email protected]>
…est.ts Co-authored-by: Wyatt Barnes <[email protected]>
#5748) * Init TransactionWithFromLocalWalletIndex, TransactionWithToLocalWalletIndex, TransactionWithToAndFromLocalWalletIndex types * Add null to Transaction.to * Rename TransactionWithToAndFromLocalWalletIndex to TransactionWithFromAndToLocalWalletIndex
jdevcs
approved these changes
Jan 13, 2023
spacesailor24
approved these changes
Jan 13, 2023
spacesailor24
deleted the
nikos/5711/TransactionWithLocalWalletIndex-should-support-to-as-a-wallet-index
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #5711
Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.