-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding webpack 5 #5649
adding webpack 5 #5649
Conversation
Pull Request Test Coverage Report for Build 3525432817Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have some problems with encrypt/decrypt the wallet in tests. Can it be related to webpack config?
@avkos yes, a browser test was failing due to the upgrade. its passing now |
new webpack now produces a web3.min.js.lincese.txt
Its an MIT license for some modules, it looks ok to keep |
Description
(#5629) Webpack 4 -> Webpack 5:
As well an update to webpack, the build size has been made smaller with optimizations in webpack configs.
Packages were added to dev-dependencies due to breaking changes upgrading to webpack 5
previously: 1.39mb
current: 1.31mb
edit: was able to improve and now 1.12-1.13mb
Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.