-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5601 - fix next.js builds on node v16 #5619
Conversation
Your Render PR Server URL is https://atweb3js-docs-pr-5619.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cdpbrgpa6gdn18j7slig. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the tests are falling. It will be great to fix them
Pull Request Test Coverage Report for Build 3516153864Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Description
#5601
this PR fixes builds on next.js when being built with node v16, I believe
global.request
was being changed due to a polyfill issue and was giving an errorTypeError: Cannot set property Request of # which has only a getter
and its due torequire('abortcontroller-polyfill/dist/polyfill-patch-fetch')
The solution is to only include
require('abortcontroller-polyfill/dist/polyfill-patch-fetch')
when abortController is not defined globally. I believe next.js provides their own global variables and would run into an error whenRequest
was being polyfilled.Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.